Live Viewer shows spectrum of images via caching recent images #2425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeSullivan7
force-pushed
the
live_viewer_caching
branch
from
8a622ff to
d0a34e3
Compare
samtygier-stfc
requested changes
Dec 10, 2024
samtygier-stfc
requested changes
Dec 12, 2024
…e buffered into the spectrum
…r.update_image_list
…_from_cache_THEN_image_is_not_in_cache and test_WHEN_oldest_image_got_THEN_get_oldest_image
…added_to_cache, test_WHEN_image_in_cache_when_loaded_then_image_taken_from_cache, test_WHEN_cache_full_THEN_loading_image_removes_oldest_image
MikeSullivan7
force-pushed
the
live_viewer_caching
branch
from
33f793f to
c0e5875
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Closes 2421
Description
An ImageCache has been implemented in the Live Viewer which holds a dictionary of a given size, which image data is stored in. When loaded through the ImageCache, if the image is already in cache, the data is returned without further computation. This provides a performance improvement with compromise of using RAM.
The Live Viewer now has the option to show the spectrum of live data via a right click menu. If the ROI is not moved, the mean spectrum of the newest image is added to the plotted spectrum. If the ROI is moved, all previous images are loaded in a loop, where the mean is stored and plotted. This is done in a separate thread to prevent loss of interaction with the GUI. The calculation of the mean also uses the ImageCache to speed up calculation for those images stored in the cache.
Testing
make check
Acceptance Criteria
Open MI and the Live Viewer Window
Right click and click Operations -> Calculate Spectrum
Move images into LV directory via a script and check that the Spectrum is calculated as expected.
While images are incoming, move the ROI and check that the Spectrum recalculates and plots with no interruption of the GUI.
Documentation
Release Note